Skip to content

svelte: Port LoadingSpinner component from Ember.js app #12561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Turbo87 merged 2 commits into from
Dec 22, 2025
+77 −7
Merged

svelte: Port LoadingSpinner component from Ember.js app #12561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7e63f7
svelte: Port `LoadingSpinner` component from Ember
Turbo87 Dec 19, 2025
d4e3cbe
svelte/PageHeader: Use `LoadingSpinner` component
Turbo87 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions svelte/src/lib/components/LoadingSpinner.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<script module>
import { defineMeta } from '@storybook/addon-svelte-csf';
import LoadingSpinner from './LoadingSpinner.svelte';
const { Story } = defineMeta({
title: 'LoadingSpinner',
component: LoadingSpinner,
tags: ['autodocs'],
argTypes: {
theme: {
control: 'inline-radio',
options: [undefined, 'light'],
},
},
});
</script>

<Story name="Default" />

<Story name="Light Theme" args={{ theme: 'light' }} />

<Story name="Custom Size" asChild>
<LoadingSpinner style="--spinner-size: 32px;" />
</Story>
50 changes: 50 additions & 0 deletions svelte/src/lib/components/LoadingSpinner.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<script lang="ts">
import type { HTMLAttributes } from 'svelte/elements';

interface Props extends HTMLAttributes<HTMLDivElement> {
theme?: 'light';
}

let { theme, class: className, ...restProps }: Props = $props();
</script>

<div class={['spinner', theme, className]} {...restProps}>
<span class="sr-only">Loading...</span>
</div>

<style>
.spinner {
--spinner-color: currentcolor;
--spinner-bg-color: var(--gray-border);
--spinner-size: 16px;

display: inline-block;
height: var(--spinner-size);
width: var(--spinner-size);

&:global(.light) {
--spinner-bg-color: rgba(0, 0, 0, 0.2);
}

&::after {
content: ' ';
display: block;
box-sizing: border-box;
width: var(--spinner-size);
height: var(--spinner-size);
border-radius: 50%;
border: calc(var(--spinner-size) / 5.5) solid var(--spinner-color);
border-color: var(--spinner-bg-color) var(--spinner-bg-color) var(--spinner-color) var(--spinner-bg-color);
animation: spinner 1.2s linear infinite;
}
}

@keyframes spinner {
0% {
transform: rotate(0deg);
}
100% {
transform: rotate(360deg);
}
}
</style>
9 changes: 2 additions & 7 deletions svelte/src/lib/components/PageHeader.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import type { Snippet } from 'svelte';
import type { HTMLAttributes } from 'svelte/elements';
// TODO: import LoadingSpinner from './LoadingSpinner.svelte';
import LoadingSpinner from '$lib/components/LoadingSpinner.svelte';
interface Props extends HTMLAttributes<HTMLDivElement> {
title?: string;
Expand All @@ -24,8 +24,7 @@
<small class="suffix">{suffix}</small>
{/if}
{#if showSpinner}
<!-- TODO: <LoadingSpinner class="loading-spinner" data-test-spinner /> -->
<span class="loading-spinner" data-test-spinner>Loading...</span>
<LoadingSpinner style="margin-left: var(--space-2xs)" data-test-spinner />
Copy link
Contributor

@eth3lbert eth3lbert Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity that Svelte doesn't have many options for overriding a child component's styles. I hope a better solution comes along someday! 🥲

Copy link
Member Author

@Turbo87 Turbo87 Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that part is certainly annoying... :-/

{/if}
</h1>
{/if}
Expand All @@ -49,8 +48,4 @@
color: var(--main-color-light);
padding-left: var(--space-2xs);
}
.loading-spinner {
margin: 0 var(--space-2xs);
}
</style>