Expose more fields in beacon as pub #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to not just parse but also generate these frames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I want to not just parse beacon frames but also send them. So I exposed all needed fields to create them.
Since the lists were represented by a pair of length and array, and I wanted to ensure it was impossible to have inconsistent state, I replaced those by
heapless::Vec. Let me know if this dependency is ok for you.This made some parts of the frames no longer
Copy, but I think that is a good thing, since some structs got quite big to copy. (e.g.PendingAddressis 70 bytes)