Conversation
Signed-off-by: tanyan <kisumtan93@gmail.com>
Signed-off-by: tanyan <kisumtan93@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the Exception Class (EC) field definitions in the ESR_EL1 and ESR_EL2 registers according to the ARM Architecture Reference Manual. The changes expand the previously incomplete EC field enumerations from basic exception types to comprehensive lists covering all exception classes defined in the ARM architecture.
Key Changes
- Added missing exception codes including new architecture features (FEAT_MOPS, FEAT_GCS, FEAT_TME, FEAT_SME, etc.)
- Improved documentation for each EC value with clearer descriptions
- Added feature annotations (e.g., FEAT_AA32, FEAT_BTI, FEAT_SVE) to indicate architecture extension requirements
- Updated copyright year to 2025 and added new contributor
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| src/registers/esr_el2.rs | Expanded EC field from 21 to 32 exception codes, added comprehensive documentation and feature annotations for all exception classes |
| src/registers/esr_el1.rs | Expanded EC field from 21 to 28 exception codes, added documentation and feature annotations, though missing some entries that should be present |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
thejpster
reviewed
Dec 1, 2025
| TrappedMCRorMRC2 = 0b00_0101, | ||
| /// Trapped LDC or STC access (FEAT_AA32) | ||
| TrappedLDCorSTC = 0b00_0110, | ||
| /// Access to SME, SVE, Advanced SIMD or floating-point functionality trapped |
Member
There was a problem hiding this comment.
Will update, thanks for noticing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the EC fields in the ESR_EL1 and ESR_EL2 registers according to the ESR_EL1 and ESR_EL2 doc