fix(printer.rs): include ZeroSized FnDef consts in functions #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Add a test case that reproduces issue #55 where function pointers passed as arguments (e.g. to Option::map) are not captured in the functions array. Also update normalise-filter.jq to filter unstable type IDs in ArrayType.size.kind.Value.
Zero-sized constants can represent function items (FnDef) used as values, e.g. when passing a function pointer to a higher-order function. This ensures such functions are included in the link map so they appear in the `functions` array of the SMIR JSON. Fixes #55
Stevengre
force-pushed
the
jh/print-function-pointer
branch
from
787a38b to
ea3606b
Compare
When LINK_INST is disabled, the link map key only contains Ty without instance kind, so different instances (Item vs ReifyShim) of the same function type would conflict. Instead of using a heuristic preference function, we now: - Skip ReifyShim entries if an Item entry already exists - Replace ReifyShim entries with Item entries when encountered This is cleaner because ReifyShim has no body in items (it's generated by the linker), so Item is always more useful.
Stevengre
force-pushed
the
jh/print-function-pointer
branch
from
ea3606b to
940f2da
Compare
Stevengre
force-pushed
the
jh/print-function-pointer
branch
from
31f5ec3 to
0253b9c
Compare
jberthold
reviewed
Dec 16, 2025
| # Remove the hashes at the end of mangled names | ||
| .functions = ( [ .functions[] | if .[1].NormalSym then .[1].NormalSym = .[1].NormalSym[:-17] else . end ] ) | ||
| | .items = ( [ .items[] | if .symbol_name then .symbol_name = .symbol_name[:-17] else . end ] ) | ||
| | .items = ( [ .items[] | if .symbol_name then .symbol_name = .symbol_name[:-17] else . end ] | map(walk(if type == "object" then del(.ty) else . end)) ) |
Member
There was a problem hiding this comment.
This is not necessary because
a) it is done again in line 6
b) there can only be NormalSym, NoopSym or IntrinsicSim, with no further fields.
Sorry, I misread this. However, we should place this further down in the "filtering" section instead of up here where we only want to adjust the function names.
jberthold
reviewed
Dec 16, 2025
| # delete unstable alloc, function, and type IDs | ||
| | .allocs = ( .allocs | map(del(.alloc_id)) | map(del(.ty)) ) | ||
| | .functions = ( [ .functions[] ] | map(del(.[0])) ) | ||
| | .functions = ( [ .functions[] ] | map(del(.[0])) | map(walk(if type == "object" then del(.ty) else . end)) ) |
Member
There was a problem hiding this comment.
not necessary because there can only be NormalSym, NoopSym or IntrinsicSim, with no further fields.
Suggested change
| | .functions = ( [ .functions[] ] | map(del(.[0])) | map(walk(if type == "object" then del(.ty) else . end)) ) | |
| | .functions = ( [ .functions[] ] | map(del(.[0])) ) |
jberthold
approved these changes
Dec 16, 2025
Member
jberthold
left a comment
jberthold
left a comment
There was a problem hiding this comment.
LGTM, thanks for adjusting!
automergerpr-permission-manager
bot
deleted the
jh/print-function-pointer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functionslookup array #55 (and downstream.map(...)desugaring not supported → leads tounknown function -1mir-semantics#891 Support function pointers as callees mir-semantics#488).