extension: Make it if cleanup fails RuleCondition test does nothing #22592
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-web
danielhjacobs
force-pushed
the
danielhjacobs-patch-10
branch
from
bd47ce8 to
252f7b8
Compare
Contributor
Author
Member
|
Is it somehow possible that we need cleanup even if |
Contributor
Author
|
We shouldn't i don't think as it's only false if the rule registering throws in both trys (which should mean no rules were registered). |
Contributor
Author
|
The code was suggested by Rob--W of the Mozilla extension team: w3c/webextensions#638 (comment) |
Member
|
(I just don't understand the PR title / commit message ... is there a word missing?) |
Contributor
Author
|
Make it (so) if cleanup fails (the) RuleCondition test (still) does nothing |
danielhjacobs
force-pushed
the
danielhjacobs-patch-10
branch
from
252f7b8 to
684a7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section of code tests if the responseHeaders RuleCondition is supported and not behind a flag, but if the RuleCondition is enabled behind a flag it will successfully register a rule which matches any request, even if it doesn't match the unsupported RuleCondition. What that means is on Chromium 121-127 a rule is registered via lines 37 - 50 that blocks every request. It shouldn't matter though, as that rule is removed by lines 57 - 59, but just in case that fails to remove the rule, it's better if the rule does nothing.