Skip to content

Conversation

@TheSalarKhan
Copy link

@TheSalarKhan TheSalarKhan commented Oct 22, 2024

Hi @rubenv

Thanks allot for the amazing library, you might find this cool - maybe slightly concerning 🤣 - but we're using pgtest to spin up temporary databases on the network, to provide quick databases for testing purposes.

tl;dr we simply pipe TCP connections to unix sockets for pgtest instances spun up in real-time.

But we can't do this unless we have predefined passwords/dbnames set (security, its on the network!). And in some instances - for longer running/multi-phase usecases - we need to disable Fsync.

So I've added options to the pgtest.PGConfig config builder, which are used by the core start method to tailor for specific cases.

I have added tests that make sure this works.

Raising this PR in hopes that it unlocks more use-cases for this work of art.

Thanks a ton!

Copy link

@CodeAshing CodeAshing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work @TheSalarKhan

@karelbilek
Copy link

I am not a maintainer here at all, but I personally find this a bit out of scope for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants