Comments for the DoctoR #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .idea to .gitignore
Contains feature/todo and a bunch of formatting.
This does plenty of things. Actually, too many for a single feature. But mostly it's considering beauty, so, here is what it does: * Delete unused code - in the sum the file is ~90 lines shorter or so. * Get rid of unnecessary preprocessor directives * Map the papers `Algorithm 2` via comments * Add a License template * Add a bunch of TODOs * Enhance output
Output file optim.dat is now written in the same directory, where the executable is called from.
The python testing script runs various test cases and compares the output with the saved optim file (simple vimdiff). By default, maxlevels = 1 and 10 are tested running on 1, 2, and 5 cores each. Only the peaks example is tested so far.
The peaks example now runs with N=32 layers. Validation accuracy about 90% after 130 iteraions. Uses One-shot, i.e. only 2 xBraid iterations in each optimization cycle.
The python testing script runs various test cases and compares the output with the saved optim file (simple vimdiff). By default, maxlevels = 1 and 10 are tested running on 1, 2, and 5 cores each. Only the peaks example is tested so far.
Output file optim.dat is now written in the same directory, where the executable is called from.
Merge a set of features w/ regard to readability/testability
Update email address in Readme.me Contributors
Update list of contributors
Fix null pointer constant
Not very much though... Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.