Skip to content

Conversation

@Y-LyN-10
Copy link

@Y-LyN-10 Y-LyN-10 commented Oct 8, 2018

Refers #43

Hey. I just noticed that there are already 2 PRs for Hapi v17 Support, but I have already spent half of my day to make these changes (lessons learned).

Although, I believe that this PR has it's merit as it's absolutely up-to-date, so maybe you could take a look, please?

Here is a list of changes:

  • Updated the hapi plugin to work with async/await
  • Updated the tests accordingly (to the async server)
  • Updated the example and manually verified that it runs on Docker with no issues with the latest changes
  • Updated vulnerable npm dependencies, so "npm audit" now returns "found 0 vulnerabilities"
  • I've been trying to follow the existing code style (i.e no semicolons), but following hapi.js code conventions for the API usage)
  • Documentation updates

If you consider this PR, I pledge to follow-up on any feedback regarding additional changes in a timely manner 🙏

@jimgreenejr
Copy link

Any chance this is going to get merged? Hopefully the third times the charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants