Open
Conversation
|
@roverdotcom Can this be merged in please? |
|
I really need this. Please merge. |
|
You can use this branch directly with pip or poetry: $ poetry add git+https://github.com/blocher/django-inlinecss.git#django4or $ pip install django-inlinecss@git+https://github.com/blocher/django-inlinecss.git@django4 |
|
I tried to update Django version to 4.0.6, but failed due to this package. |
DarknessRdg
approved these changes
Oct 2, 2022
DarknessRdg
left a comment
DarknessRdg
left a comment
There was a problem hiding this comment.
It looks really great to me.
It fixes the breaking change and many are looking for this.
I hope this bug fix can be released soon enough!
|
Do we have a people with Merge/Release abilities for this repo? Who is the maintainer? |
rigoplz
approved these changes
Nov 15, 2022
|
Hello,
We are using it, but because of legacy issues... We just cannot get rid of
it instantly, but at the same time we are having deprication policy for it.
I have tried to contact the author, no luck... The only downside - either
you will have to use forks to support newer python versions or Django
versions, or you have to stuck at old dependencies, meaning all your stack
will be outdated.
We are updating our deps constantly, therefore it is not good for us to
stuck in the past...
Note: but the package is still working, even for new codebase - you can
find a fork in the issue comments.
…On Tue, May 16, 2023, 17:08 thomasb ***@***.***> wrote:
Is this module worth forking if it's not currently being maintained?
—
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUWBFEVJFVTAEFJX3UVBL3XGN36VANCNFSM5O3RHSNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to run with Django 4.0+: using smart_str instead of smart_text