Skip to content

Remove the import of Literal from entity.py. #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clalancette merged 1 commit into from
Mar 6, 2023
Merged

Remove the import of Literal from entity.py. #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions launch/launch/frontend/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"""Module for Entity class."""

from typing import List
from typing import Literal
from typing import Optional
from typing import overload
from typing import Text
Expand Down Expand Up @@ -51,14 +50,9 @@ def children(self) -> List['Entity']:
# - If no data type is passed, the return type is str. Similar to the above, it has two
# possibilities: present or not present.
# => 6 overloads to cover every combination
@overload
def get_attr(self, name: Text, *, data_type: Type[TargetType],
optional: Literal[False], can_be_str: bool = True) -> TargetType:
...

@overload
def get_attr(self, name: Text, *, data_type: Type[TargetType], # noqa: F811
optional: Literal[True], can_be_str: bool = True) -> Optional[TargetType]:
optional: bool, can_be_str: bool = True) -> Optional[TargetType]:
...

@overload
Expand All @@ -67,12 +61,7 @@ def get_attr(self, name: Text, *, data_type: Type[TargetType], # noqa: F811
...

@overload
def get_attr(self, name: Text, *, optional: Literal[False], # noqa: F811
can_be_str: bool = True) -> str:
...

@overload
def get_attr(self, name: Text, *, optional: Literal[True], # noqa: F811
def get_attr(self, name: Text, *, optional: bool, # noqa: F811
can_be_str: bool = True) -> Optional[str]:
...

Expand Down