RateLimiter: Don't update parameters before input checks #437 #2074
+62
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
christophfroehlich and
mhubii
8 tasks
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
If we set all parameters as read-only, there would not be the need for the changes in ros-controls/control_toolbox#554
I think that we could allow to change the limits during runtime as mentioned here and here. what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros-controls/control_toolbox#437
I submitted two pull requests: one in the ros2_controllers repository and another in the control_toolbox repository.
The current PR addressed the following: