Skip to content

Conversation

@saikishor
Copy link
Member

@saikishor saikishor commented Dec 6, 2025

This PR adds some changes to the Spawner to allow it to define the controller args per controller rather than global args for all the controllers.

I've added a new function in the launch_utils and I tested it using the following changes in example_12
https://github.com/ros-controls/ros2_control_demos/blob/advanced_spawner/example_12/bringup/launch/rrbot.launch.py

@saikishor saikishor changed the title Advanced spawner allowing arguments per controller [Spawner] Allow arguments per controller instead of global args Dec 6, 2025
@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 81.97115% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.23%. Comparing base (dca9b57) to head (383c07b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...troller_manager/controller_manager/launch_utils.py 2.56% 38 Missing ⚠️
controller_manager/controller_manager/spawner.py 78.50% 15 Missing and 8 partials ⚠️
controller_manager/test/test_advanced_spawner.cpp 94.81% 0 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
- Coverage   89.39%   89.23%   -0.16%     
==========================================
  Files         155      156       +1     
  Lines       18209    18584     +375     
  Branches     1483     1522      +39     
==========================================
+ Hits        16278    16584     +306     
- Misses       1337     1388      +51     
- Partials      594      612      +18     
Flag Coverage Δ
unittests 89.23% <81.97%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/test/test_advanced_spawner.cpp 94.81% <94.81%> (ø)
controller_manager/controller_manager/spawner.py 73.47% <78.50%> (+1.96%) ⬆️
...troller_manager/controller_manager/launch_utils.py 22.97% <2.56%> (-22.75%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant