Open
Conversation
Sort digram frequency count
Owner
|
Thank you, I will update the next version of the book to include your changes. It is going into the 4th printing now so this will probably occur sometime in 2021. |
Owner
|
We are getting ready for the next printing and I noticed that your code is doubling the frequency count for digrams like "vo." It looks like you overwrite the digrams set with this line: digrams = sorted([''.join(i) for i in permutations(name, 2)]) When you print out the list of digrams, you'll see that several are duplicated, which can't happen with a set data type. This is overall a good approach however, and I plan to include an edited version in the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify digram generation and sort
Sort digram frequency count