Show set count from current period in Head-to-Head #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added "This Period" set count (doesn't actually work yet)
- MatchesResource modified to return
- qualifying_matches: matches played in current PR period
- curWins: : matches won in current PR period
- curLosses: : matches lost in current PR period
- head 2 head controller obtains won/lost matches
- Added comments to headtohead - Changed added variables in python to follow naming conventions
BrandonCookeDev
requested review from
BrandonCookeDev
and removed request for
jschnei
BrandonCookeDev
requested changes
Feb 10, 2018
Collaborator
There was a problem hiding this comment.
Everything looks great code wise! However the Python code is failing 2 Unit tests.
These tests more than likely are missing the new qualifying_matches property you added to the return_dict.
They need to be altered to include this data and pass before the PR can be approved. Details below:
======================================================================
FAIL: test_get_matches (test.test_server.TestServer)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/deploy/stage/garpr/test/test_server.py", line 968, in test_get_matches
self.assertEquals(len(json_data.keys()), 5)
AssertionError: 8 != 5
======================================================================
FAIL: test_get_matches_with_opponent (test.test_server.TestServer)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/deploy/stage/garpr/test/test_server.py", line 1008, in test_get_matches_with_opponent
self.assertEquals(len(json_data.keys()), 6)
AssertionError: 9 != 6
----------------------------------------------------------------------
Ran 196 tests in 40.473s
FAILED (failures=2, skipped=2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image with current ranking period set to 550 days because it was faster than figuring out how to download the current database