when finalizing a tournament, validate that multiple player aliases #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shGGScraper object. Added tests. Passes all tests.
Need to check if double counting happens
…ble counting the matches we already accounted for in the url.
Altered tests to apply to recursive match pulling.
Functions to get raw groups and phaseid Recoded getting phase ids. Should correctly extract all pool id's that we can use to get the brackets. Quick bug fix Shifting things so it will keep working. Creating method to pull back pools into an array of SmashGG objects Successfully retrieving all phase id's from an event. Passing all tests. Successfully retrieves pools and stores them as a property in the SmashGGScraper object. Added tests. Passes all tests. Eradicated the infinite recursion (via object property). Need to check if double counting happens Added in condition to recursively pulling pools matches. Prevents double counting the matches we already accounted for in the url. Added Recursive Pools grabbing code to SmashGG match pulling. Altered tests to apply to recursive match pulling.
* Setting up api pull. Smash GG object takes a tournament id and pulls back json api data. * Function created to get all participant smashtags. Method also has the ability to grab additional data on a player. (Mostly feeling out the api as well) * Created a subclass to contain relevant smashGG data about players. Created a method to resolve a SmashGG player object from an id. * Small bug fixes with getting player by id * Added method to get matches. Reformatted test structure to that of unit testing. * Updated SmashGG unit tests to be more robust. Altered logic to generate smashgg player objects to grab the state if a region is not defined. Can be reversed later if not adequate * Added a static method to pull the bracket id from a raw url, since this id is how we are able to pull from the api. * Needed a new method to retrieve the entrant id. Use the entrant id to resolve the player name for the match objects. Added test cases for these new functions. Moved SmashGG test data to it's rightful folder in test_scraper/data * Added method to pull the tournament name from the url. Added respective test cases. * Added method to pull all matches and capture extra data that could be useful for metrics in the future. Added tests for method. * Added round name to the SmashGGMatch object * Rearranged logic of SmashGGPlayer object creator. Added os-specific separators for the files in the test suite. * Changed test data to be not formatted so it passes the tests now. Changed tests to os absolute path of the json test files. * Cleaned up test suite for the PR * Delete garpr - Shortcut.lnk * Update .gitignore because of previous commit accidentally committing a windows link * fix double issue * fixed one bug in test cases, still failing tho * Corrected documentation in smashGG module. Removed uneccessary imports in module. Going to implement substitute get_raw functions shortly. * Updated test with some substitutes for get_raw. should revisit later when api may be complete. * Quick, important error handling for SmashGG Match Results. * Initial commit of Log module and its unit test. Need to write short documentation on Usage. * Added static method to include the module in the error/logging message. * Updated default logging function to handle two parameters differently. Should help us log at a higher level of granularity for we can write the module where the error occurred in the log. Added another test to handle different params * Included small readme on usage. Should help developers jump right in * Changed folder name to garprLogging * Updated README with corrected import * Quick fix for test_write_file2 in test_log * Added Logging error handling to the SmashGG Module * Added on more error handling in the SmashGG module. Need to figure out what to return on error. * Revert "Added Logging error handling to the SmashGG Module" This reverts commit bbe5e3b. * Refactored SmashGG to take a url. From that it will parse out the id from the path. Refactored tests for this change. Preparing the Tournament Importer and Server files for SmashGG implementation * Added SmashGG impl to tournament import service * Small extra edited server file for Brandon Cooke * Added a quick unit test for checking tag duplication in brackets * Reimplemented Player pull. Fixing methods to pass unit tests * Quick bug fix where name populated with smash tag * Refactored SmashGG Pull -No duplicates -Passes all tests * Added a quick unit test for checking tag duplication in brackets Reimplemented Player pull. Fixing methods to pass unit tests Quick bug fix where name populated with smash tag Refactored SmashGG Pull -No duplicates -Passes all tests * Removing cookiE's specific server file * Changed smashgg api url to include groups * Functions to get raw groups and phaseid * Recoded getting phase ids. Should correctly extract all pool id's that we can use to get the brackets. * Quick bug fix * Shifting things so it will keep working. * Creating method to pull back pools into an array of SmashGG objects * Successfully retrieving all phase id's from an event. Passing all tests. * Successfully retrieves pools and stores them as a property in the SmashGGScraper object. Added tests. Passes all tests. * Eradicated the infinite recursion (via object property). Need to check if double counting happens * Added in condition to recursively pulling pools matches. Prevents double counting the matches we already accounted for in the url. * Added Recursive Pools grabbing code to SmashGG match pulling. Altered tests to apply to recursive match pulling. * Changed smashgg api url to include groups Functions to get raw groups and phaseid Recoded getting phase ids. Should correctly extract all pool id's that we can use to get the brackets. Quick bug fix Shifting things so it will keep working. Creating method to pull back pools into an array of SmashGG objects Successfully retrieving all phase id's from an event. Passing all tests. Successfully retrieves pools and stores them as a property in the SmashGGScraper object. Added tests. Passes all tests. Eradicated the infinite recursion (via object property). Need to check if double counting happens Added in condition to recursively pulling pools matches. Prevents double counting the matches we already accounted for in the url. Added Recursive Pools grabbing code to SmashGG match pulling. Altered tests to apply to recursive match pulling.
* basic backend for undoable merges * add very basic mongo_validation script; should be fleshed out later * basic frontend for looking at past merges * frontend for undoing merges * updated tests
… This will help us identify problems with specific tournament imports later on.
Conflicts: scraper/smashgg.py
* Setting up api pull. Smash GG object takes a tournament id and pulls back json api data. * Function created to get all participant smashtags. Method also has the ability to grab additional data on a player. (Mostly feeling out the api as well) * Created a subclass to contain relevant smashGG data about players. Created a method to resolve a SmashGG player object from an id. * Small bug fixes with getting player by id * Added method to get matches. Reformatted test structure to that of unit testing. * Updated SmashGG unit tests to be more robust. Altered logic to generate smashgg player objects to grab the state if a region is not defined. Can be reversed later if not adequate * Added a static method to pull the bracket id from a raw url, since this id is how we are able to pull from the api. * Needed a new method to retrieve the entrant id. Use the entrant id to resolve the player name for the match objects. Added test cases for these new functions. Moved SmashGG test data to it's rightful folder in test_scraper/data * Added method to pull the tournament name from the url. Added respective test cases. * Added method to pull all matches and capture extra data that could be useful for metrics in the future. Added tests for method. * Added round name to the SmashGGMatch object * Rearranged logic of SmashGGPlayer object creator. Added os-specific separators for the files in the test suite. * Changed test data to be not formatted so it passes the tests now. Changed tests to os absolute path of the json test files. * Cleaned up test suite for the PR * Delete garpr - Shortcut.lnk * Update .gitignore because of previous commit accidentally committing a windows link * fix double issue * fixed one bug in test cases, still failing tho * Corrected documentation in smashGG module. Removed uneccessary imports in module. Going to implement substitute get_raw functions shortly. * Updated test with some substitutes for get_raw. should revisit later when api may be complete. * Quick, important error handling for SmashGG Match Results. * Initial commit of Log module and its unit test. Need to write short documentation on Usage. * Added static method to include the module in the error/logging message. * Updated default logging function to handle two parameters differently. Should help us log at a higher level of granularity for we can write the module where the error occurred in the log. Added another test to handle different params * Included small readme on usage. Should help developers jump right in * Changed folder name to garprLogging * Updated README with corrected import * Quick fix for test_write_file2 in test_log * Added Logging error handling to the SmashGG Module * Added on more error handling in the SmashGG module. Need to figure out what to return on error. * Revert "Added Logging error handling to the SmashGG Module" This reverts commit bbe5e3b. * Refactored SmashGG to take a url. From that it will parse out the id from the path. Refactored tests for this change. Preparing the Tournament Importer and Server files for SmashGG implementation * Added SmashGG impl to tournament import service * Small extra edited server file for Brandon Cooke * Added a quick unit test for checking tag duplication in brackets * Reimplemented Player pull. Fixing methods to pass unit tests * Quick bug fix where name populated with smash tag * Refactored SmashGG Pull -No duplicates -Passes all tests * Added a quick unit test for checking tag duplication in brackets Reimplemented Player pull. Fixing methods to pass unit tests Quick bug fix where name populated with smash tag Refactored SmashGG Pull -No duplicates -Passes all tests * Removing cookiE's specific server file * Changed smashgg api url to include groups * Functions to get raw groups and phaseid * Recoded getting phase ids. Should correctly extract all pool id's that we can use to get the brackets. * Quick bug fix * Shifting things so it will keep working. * Creating method to pull back pools into an array of SmashGG objects * Successfully retrieving all phase id's from an event. Passing all tests. * Successfully retrieves pools and stores them as a property in the SmashGGScraper object. Added tests. Passes all tests. * Eradicated the infinite recursion (via object property). Need to check if double counting happens * Added in condition to recursively pulling pools matches. Prevents double counting the matches we already accounted for in the url. * Added Recursive Pools grabbing code to SmashGG match pulling. Altered tests to apply to recursive match pulling. * Changed smashgg api url to include groups Functions to get raw groups and phaseid Recoded getting phase ids. Should correctly extract all pool id's that we can use to get the brackets. Quick bug fix Shifting things so it will keep working. Creating method to pull back pools into an array of SmashGG objects Successfully retrieving all phase id's from an event. Passing all tests. Successfully retrieves pools and stores them as a property in the SmashGGScraper object. Added tests. Passes all tests. Eradicated the infinite recursion (via object property). Need to check if double counting happens Added in condition to recursively pulling pools matches. Prevents double counting the matches we already accounted for in the url. Added Recursive Pools grabbing code to SmashGG match pulling. Altered tests to apply to recursive match pulling. * Added code in constructors to setup dedicated log files for scrapers. This will help us identify problems with specific tournament imports later on. * Quick bug fix for logging scrapers * Quick bug fix for logging in SmashGG * Added teardown to unit tests to avoid memgen * Quick changes * Bug Fix: Parse content to utf8. Should handle issues with logging json data * Bug Fix: Ignore enicode that brings down program * quick fixes to get SmashGG scraping working
* disable SSLv3 and serve entire cert chain * added list of secure ciphers
* whitelist all local IPs for CORS * add garpr.com to CORS whitelist
Mobile UI using bootstrap media queries: * Mobile UI about 75% Complete * Most common UI funtions are now ready for mobile. * Added simple collasible navbar * Made collapsed navbar menu icon and brand name more presentable on mobile UI * Interim collpased navbar * Made nav dropdown font bigger * updated player details button * Lots of alterations to what inputs and modals look like on mobile devices * Just about all modals and inputs are mobile ready * Changed navbar text input to also be mobile applicable * Made the garpr banner image a link back to rankings page. A few more tweaks
… therefore their most active region)
add logic to show the player's region with te lowest sigma value (and…
fix variable reference
don't map to a single player id.
Collaborator
|
this should probably be checked in PendingTournament.validate_document in model.py (other validation stuff is done there; I thought I also checked for this, but it looks like I only check to make sure players don't play themselves). |
BrandonCookeDev
force-pushed
the
master
branch
from
d1a9e59 to
21b9705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't map to a single player id.