Open
Conversation
nathanejohnson
force-pushed
the
feature/dynamic_tls_reload
branch
9 times, most recently
from
9d759bc to
b8b8d3c
Compare
This is a very simple implementation. It optionally polls the disk for changes to the key / cert files, and attempts to reload them if it detects the modification time or the size has changed.
nathanejohnson
force-pushed
the
feature/dynamic_tls_reload
branch
from
b8b8d3c to
3444ebc
Compare
Author
|
I know i keep squashing changes / force pushing, but from this point I'm pretty happy with it and am running it locally so I think I'm hands off. I know some other (old, old) pending PRs have meant to solve this same issue, but this PR does it without adding any external depencies. This isn't a hard problem to solve, and there is a lot of value in solving it (to me), so I'd love to see this reviewed at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple implementation. It optionally checks the disk for changes to the key / cert files and attempts to reload them if it detects the modification time or the size has changed.
What does this PR change? What problem does it solve?
TLS hot reload
Describe the changes and their purpose here, as detailed as needed.
It is desirable to automatically start using a new certificate such as when letsencrypt renewals happen.
Was the change previously discussed in an issue or on the forum?
yes, #94
Checklist
changelog/unreleased/that describes the changes for our users (see template).