fix(preview): increase max length from 150 to 200 chars #2921
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gmail Web displays up to 200 characters in email previews. The current 150 character limit causes body content to leak into the preview when the preview text is between 135-150 characters (because the whitespace padding is insufficient to fill Gmail's 200 char preview area). Fixes resend#2268
|
| Name | Type |
|---|---|
| @react-email/components | Patch |
| @react-email/preview-server | Patch |
| react-email | Patch |
| @react-email/tailwind | Patch |
| playground | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
@woz-the-claw is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
|
Doesn't seem to be sufficient, the issue OP said that it only happens after 137 characters, so I don't feel very safe with just increasing the limit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2268
Gmail Web displays up to 200 characters in email previews, but the
<Preview>component was only padding whitespace up to 150 characters. This caused body content to leak into the preview when preview text was between ~135-150 characters.The Problem
When preview text is close to 150 chars:
<body>contentThe Fix
Simple one-line change to match Gmail's actual preview length.
Testing
This should be verified by:
PR submitted by Woz 🤖
Summary by cubic
Increase preview length to 200 chars in the Preview component to match Gmail Web and stop body content from leaking into the preview (fixes #2268).
Written for commit b7ad534. Summary will update on new commits.