Skip to content

Conversation

@cpenned
Copy link
Contributor

@cpenned cpenned commented Jan 29, 2026


Summary by cubic

Adds a comprehensive test suite for the React Email skill and expands SKILL.md with install steps, static image guidance, and stricter layout/styling rules. Improves reliability across dev and production and prevents common email‑client pitfalls.

  • New Features

    • Added skills/react-email/TESTS.md with scenario-based tests covering client limitations, static assets, layout rules, Tailwind config (pixelBasedPreset, Head placement), buttons, code blocks, i18n/RTL, plain text, and size warnings.
    • Includes pressure tests to prevent SVG/WEBP usage, flexbox/grid, media queries, dark: variants, incorrect image paths, relative asset paths, and localhost hardcoding.
    • Each test defines clear pass criteria for TDD and regression checks.
  • Refactors

    • Updated skills/react-email/SKILL.md with “Before Writing Code” questions (brand color, logo format, tone, production asset URL).
    • Added installation and dev-server setup, tsconfig notes, and the dev/prod baseURL pattern; instruct users to host images under emails/static and provide their production URL.
    • Clarified layout/styling rules: use table-based Row/Column with widths, include pixelBasedPreset, place Head inside Tailwind, require box-border on buttons, specify/reset borders, wrap CodeBlock with overflow-auto, and warn against SVG/WEBP and breakpoints/dark: variants.

Written for commit eb7ca4e. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Feb 2, 2026 0:40am
react-email-demo Ready Ready Preview, Comment Feb 2, 2026 0:40am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026

⚠️ No Changeset found

Latest commit: eb7ca4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Name Type
@react-email/components Patch
@react-email/preview-server Patch
react-email Patch
@react-email/tailwind Patch
playground Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="skills/SKILL.md">

<violation number="1" location="skills/SKILL.md:265">
P3: The new static image example uses fixed width/height attributes, which conflicts with the later guideline that says to never use fixed dimensions. Align the example with the documented rule to avoid contradictory instructions.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@gabrielmfern gabrielmfern changed the title Feat/add skill tests feat(skills): tests Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants