-
Notifications
You must be signed in to change notification settings - Fork 908
feat(skills): tests #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
feat(skills): tests #2912
Conversation
This reverts commit 5193801.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Name | Type |
|---|---|
| @react-email/components | Patch |
| @react-email/preview-server | Patch |
| react-email | Patch |
| @react-email/tailwind | Patch |
| playground | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="skills/SKILL.md">
<violation number="1" location="skills/SKILL.md:265">
P3: The new static image example uses fixed width/height attributes, which conflicts with the later guideline that says to never use fixed dimensions. Align the example with the documented rule to avoid contradictory instructions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary by cubic
Adds a comprehensive test suite for the React Email skill and expands SKILL.md with install steps, static image guidance, and stricter layout/styling rules. Improves reliability across dev and production and prevents common email‑client pitfalls.
New Features
Refactors
Written for commit eb7ca4e. Summary will update on new commits.