Restore depth image visualizers to 2D view kind (fix heuristic) #12290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxkitsune
added
📺 re_viewer
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Dec 19, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
👍 thanks!
(for reference: this is the state we had in 0.27 https://github.com/rerun-io/rerun/blob/0.27.0/crates/viewer/re_view_spatial/src/visualizers/depth_images.rs#L38)
ntjohnson1
pushed a commit
that referenced
this pull request
Dec 19, 2025
### Related * Fixes small regression from #12246 ### What Fixes depth image visualizer view spawn heuristics having no preferred view kind set by explicitly setting `SpatialViewKind::TwoD`, so they are correctly classified as 2D again.
ntjohnson1
removed
the
consider-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Fixes depth image visualizer view spawn heuristics having no preferred view kind set by explicitly setting
SpatialViewKind::TwoD, so they are correctly classified as 2D again.