Skip to content

Allow flushing telemetry without a mutable reference #11607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilk merged 1 commit into from
Oct 21, 2025
Merged

Allow flushing telemetry without a mutable reference #11607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/utils/re_perf_telemetry/src/telemetry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ pub enum TelemetryDropBehavior {
}

impl Telemetry {
pub fn flush(&mut self) {
pub fn flush(&self) {
let Self {
logs,
traces,
Expand Down Expand Up @@ -75,7 +75,7 @@ impl Telemetry {
}
}

pub fn shutdown(&mut self) {
pub fn shutdown(&self) {
// NOTE: We do both `force_flush` and `shutdown` because, even though they both flush the
// pipeline, sometimes one has better error messages than the other (although, more often
// than not, they both provide useless errors and you should make sure to look into the
Expand Down
Loading