Skip to content

Conversation

@jamesbraza
Copy link
Contributor

Adds typing-extensions>=4 for Python before 3.11 for the Self type, too.

Closes #352

@jamesbraza jamesbraza changed the title Type hinting CachedSession.__aenter__ with Self Type hinting __aenter__ with Self Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.89%. Comparing base (8d28ac7) to head (e4e0f4f).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
aiohttp_client_cache/response.py 60.00% 1 Missing and 1 partial ⚠️
aiohttp_client_cache/session.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   96.20%   95.89%   -0.32%     
==========================================
  Files          10       10              
  Lines        1081     1096      +15     
  Branches      188      113      -75     
==========================================
+ Hits         1040     1051      +11     
- Misses         30       32       +2     
- Partials       11       13       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JWCook
Copy link
Member

JWCook commented Sep 25, 2025

Thanks for contributing!

@JWCook JWCook merged commit 4ecdde2 into requests-cache:main Sep 25, 2025
6 of 8 checks passed
@jamesbraza jamesbraza deleted the typing-self branch September 25, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: CachedSession.__aenter__ returning Self type

2 participants