Skip to content

Fixes #23, utf-8 string decoding issue. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damionjunk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #23, utf-8 string decoding issue. #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9ae056
forcing incoming string encoding to ASCII-8BIT before processing
damionjunk Apr 7, 2014
c10de05
sytle- removing reassignment of mutable string
damionjunk Apr 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/edn/string_transformer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ module StringTransformer
def self.parse_string(string)
string = string.to_s
return '' if string.empty?
string.force_encoding Encoding::ASCII_8BIT
string = string.gsub(%r((?:\\[\\bfnrt"/]|(?:\\u(?:[A-Fa-f\d]{4}))+|\\[\x20-\xff]))n) do |c|
#" Clear messed up syntax highlighting with Emacs.
if u = UNESCAPE_MAP[$&[1]]
Expand Down
7 changes: 7 additions & 0 deletions spec/edn/transform_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# encoding: utf-8
require 'spec_helper'

describe EDN::Transform do
Expand Down Expand Up @@ -26,6 +27,12 @@
subject.apply(:string => 'hello\n#{world}').should == "hello\n\#{world}"
end
end

context "string-utf8" do
it "should emit a string that preserves utf-8 characters" do
subject.apply(:string => 'öhai world').should == "öhai world"
end
end

context "keyword" do
it "should emit a Ruby symbol" do
Expand Down