Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 57.81% 55.61% -2.21%
==========================================
Files 70 76 +6
Lines 6427 7462 +1035
==========================================
+ Hits 3716 4150 +434
- Misses 2424 3006 +582
- Partials 287 306 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This removes the need to declare what "interface" or type a module provides to the module system, thus being more in line with the "Go way" of implicit interfaces. The module system looks for a module with a compatible type. If multiple modules implement the same type, the module system chooses the one that was added to the builder last.
If we are going to use a view context for voting, then we need to be in the correct view before we start the voting process. Otherwise, the vote could be canceled by the following view change.
This decouples contexts from the synchronizer and makes them listen for events on the event loop.
This commit aims to make the eventloop more flexible by allowing both async and sync handlers again. Handlers can be made async by passing a RunAsync handler option. Furthermore, observers have been replaced by a WithPriority handler option.
Smart contexts that listen for timeouts
This avoids many memory allocations
johningve
force-pushed
the
optimize-mem
branch
from
e9ffe83 to
a0f05ea
Compare
Member
|
@johningve Could you resolve the conflicts in this PR before I review it? |
Member
|
I looked at this, and I like many of the changes here independent of the memory improvement gained. It probably does not make sense to try to salvage this PR as is, but perhaps we should start a new PR and redo this on top of master. @johningve Can you recall why this never moved out of draft mode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various memory optimizations.
Before:
profile (1).pb.gz
After:
profile.pb.gz