Skip to content

Replace proto.Message with msg#260

Merged
meling merged 3 commits intomasterfrom
meling/259/replace-proto-message-type-param-with-msg
Feb 8, 2026
Merged

Replace proto.Message with msg#260
meling merged 3 commits intomasterfrom
meling/259/replace-proto-message-type-param-with-msg

Conversation

@meling
Copy link
Member

@meling meling commented Feb 7, 2026

Fixes #259

Use the msg type alias more consistently instead of the proto.Message in type parameters.

@deepsource-io
Copy link
Contributor

deepsource-io bot commented Feb 7, 2026

Here's the code health analysis summary for commits ccaccf7..738d6c3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗
DeepSource Shell LogoShell✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #259 by standardizing protobuf-related generic type constraints to use the package-level msg type alias (instead of proto.Message) across core call paths and related tests.

Changes:

  • Replace proto.Message constraints/usages in type parameters with msg in unicast, multicast, and RPC helpers.
  • Update channel routing/request plumbing to use NodeResponse[msg] (and remove now-unneeded proto imports).
  • Update affected tests/benchmarks to use NodeResponse[msg] consistently.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
unicast.go Switch Unicast type parameter constraint to msg and align response channel types.
rpc.go Switch RPCCall type parameter constraints and response channel types to msg.
multicast.go Switch Multicast type parameter constraint to msg.
channel.go Update internal request/response routing plumbing to use NodeResponse[msg] and remove proto import.
responses_test.go Update test helpers and test cases to use NodeResponse[msg] and remove proto import.
channel_test.go Update helper/benchmarks to use NodeResponse[msg] consistently.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meling meling force-pushed the meling/259/replace-proto-message-type-param-with-msg branch from 7d758ae to 738d6c3 Compare February 8, 2026 00:18
@meling meling merged commit 798dbcf into master Feb 8, 2026
5 checks passed
@meling meling deleted the meling/259/replace-proto-message-type-param-with-msg branch February 8, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: replace proto.Message type parameters with msg type alias

1 participant