Merged
Conversation
Use the msg type alias more consistently.
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #259 by standardizing protobuf-related generic type constraints to use the package-level msg type alias (instead of proto.Message) across core call paths and related tests.
Changes:
- Replace
proto.Messageconstraints/usages in type parameters withmsgin unicast, multicast, and RPC helpers. - Update channel routing/request plumbing to use
NodeResponse[msg](and remove now-unneededprotoimports). - Update affected tests/benchmarks to use
NodeResponse[msg]consistently.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| unicast.go | Switch Unicast type parameter constraint to msg and align response channel types. |
| rpc.go | Switch RPCCall type parameter constraints and response channel types to msg. |
| multicast.go | Switch Multicast type parameter constraint to msg. |
| channel.go | Update internal request/response routing plumbing to use NodeResponse[msg] and remove proto import. |
| responses_test.go | Update test helpers and test cases to use NodeResponse[msg] and remove proto import. |
| channel_test.go | Update helper/benchmarks to use NodeResponse[msg] consistently. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7d758ae to
738d6c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259
Use the msg type alias more consistently instead of the proto.Message in type parameters.