Removing Manager and improve NewConfiguration typesafety#215
Draft
abjeni wants to merge 9 commits intoSalhus/prototype/quorumcall-iteratorfrom
Draft
Conversation
…ment-NewConfiguration
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype of the different design that uses a configuration in place of a manager.
The raw configuration is now a struct that points to a raw manager as well as the slice of raw nodes.
The NewConfiguration method takes a set of manager options instead of requiring a manager.
RawManager should be made private since it is no longer used by the generated files.
Sub configurations are created with a SubConfiguration method, without manager options.
There is no main configuration, the sub configurations all belong to the same raw manager.
The Close method is used to close a configuration along with all of its sub configurations.
Notes
Fixes #192