Draft
Conversation
…n to client immediately
Changed how servers reply to clients. It uses RPCCall instead of Unicast. This makes it easy to check for errors when logging. Also, refactored the broadcast processor to make it more readable.
meling
requested changes
Jan 7, 2025
Member
meling
left a comment
meling
left a comment
There was a problem hiding this comment.
I'm far from done, but I'm posting now three issues... I hope to get to this in the next few weeks.
| logger *slog.Logger | ||
| } | ||
|
|
||
| func NewBroadcastManager(logger *slog.Logger, createClient func(addr string, dialOpts []grpc.DialOption) (*Client, error), canceler func(broadcastID uint64, srvAddrs []string), order map[string]int, dialTimeout, reqTTL time.Duration, shardBuffer, sendBuffer int, allowList map[string]string, dialOpts ...grpc.DialOption) Manager { |
| ServerOriginAddr string = "server" | ||
| ) | ||
|
|
||
| type ServerHandler func(ctx context.Context, in protoreflect.ProtoMessage, broadcastID uint64, originAddr, originMethod string, options BroadcastOptions, id uint32, addr string, originDigest, originSignature []byte, originPubKey string) |
| "google.golang.org/protobuf/reflect/protoreflect" | ||
| ) | ||
|
|
||
| type Manager interface { |
Member
There was a problem hiding this comment.
Do we need an interface for this? We should be able to call the methods on the manager struct itself. Also, feels like there are too many methods available on the manager type;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.