feat(rss): add image enclosure to rss feed items #508
+101
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, works for me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redlib RSS feed items don't have images so this attempts to bring it up to feature parity with teddit.
I believe this PR handles all the relevant reddit post types (image, gallery, video, gif) and even goes a step beyond for the gallery type by embedding the number of images in the description. I also made all URLs absolute as required by the RSS 2.0 spec.
Tested with /r/gifs.rss, /r/analog.rss, /r/images.rss, and a few others for about a week running on my private instance.
Also seems to fix #420
I'm not a rust dev, so assume I don't know what I'm doing 😁