Fixes 54: Verifies that configuration files exist before trying to lo…#55
Open
AdlerFleurant wants to merge 1 commit intoredhat-cop:masterfrom
Open
Fixes 54: Verifies that configuration files exist before trying to lo…#55AdlerFleurant wants to merge 1 commit intoredhat-cop:masterfrom
AdlerFleurant wants to merge 1 commit intoredhat-cop:masterfrom
Conversation
…rying to load it.
AdlerFleurant
force-pushed
the
Fix_Issue_54
branch
from
7c4b489 to
aacefbe
Compare
Author
etsauer
requested changes
Aug 2, 2019
Collaborator
etsauer
left a comment
etsauer
left a comment
There was a problem hiding this comment.
@AdlerFleurant the core functionality changes look ok, but it also looks like you've unintentionally changed the logger. Can you undo that?
Author
|
@etsauer , can we take a look at this as without this, we can't build the cert-operator? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If configuration file is missing, the operator would fail to start with error that kind '' is not valid.
This fixes the situation and will load the default configuration if no file is present.
This issue is due do an issue in micro/go-config: https://github.com/micro/go-config/issues/99