Update deployment and rbac to work at a cluster level#43
Open
etsauer wants to merge 2 commits intoredhat-cop:masterfrom
Open
Update deployment and rbac to work at a cluster level#43etsauer wants to merge 2 commits intoredhat-cop:masterfrom
etsauer wants to merge 2 commits intoredhat-cop:masterfrom
Conversation
mathianasj
reviewed
Jun 21, 2019
Collaborator
mathianasj
left a comment
There was a problem hiding this comment.
I like how you split up the roles so that it restricts what it needs to run the operator in the namespace the container is running and what it needs to perform its tasks against routes and secrets
| - watch | ||
| - create | ||
| - update | ||
| - apiGroups: |
Collaborator
There was a problem hiding this comment.
also need to include this one so it can update existing routes
- apiGroups:
- "route.openshift.io"
resources:
- routes/custom-host
verbs:
- update
| metadata: | ||
| name: cert-operator-local | ||
| rules: | ||
| - apiGroups: |
Collaborator
There was a problem hiding this comment.
and these
- apiGroups:
- extensions
resources:
- replicasets
- deployments
verbs:
- "get"
- apiGroups:
- monitoring.coreos.com
resources:
- servicemonitors
verbs:
- "get"
- "create"
- apiGroups:
- extensions
resources:
- deployments/finalizers
resourceNames:
- cert-operator
verbs:
- "update"
Collaborator
Author
|
@mathianasj made the recommended changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mathianasj