Order of optional parameters #899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP, optional parameters should be declared after required parameters, otherwise they will be implicitly treated as required parameters.
Member
|
@samsonasik Could you look into this? |
Member
|
I will try |
samsonasik
reviewed
Dec 11, 2025
| $executeClassMethod->params = array_merge( | ||
| array_filter($executeClassMethodParams, fn(Param $param) => is_null($param->default)), | ||
| array_filter($executeClassMethodParams, fn(Param $param) => !is_null($param->default)), | ||
| ); |
Member
There was a problem hiding this comment.
@florisluiten this seems cause errors in tests fixture, see
https://github.com/rectorphp/rector-symfony/actions/runs/20064007047/job/57548394124?pr=899
Please verify other expected output fixtures, you can test locally:
composer install
vendor/bin/phpunit
Member
|
@florisluiten I've updated the rule, so it can keep correct attribute per line formatting. Hopefully it will fix the comma issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected output and potential fix for issue with InvokableCommandInputAttributeRector