-
Notifications
You must be signed in to change notification settings - Fork 25
Chore deps update #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Chore deps update #185
Conversation
We happen to inject CSSSelectorGenerator in the Blob with a slight modification of replacing cssSelectorGenerator with a readium-prefixed version. This is not necessarily maintainable as this is hardcoded, and needs to be updated cautiously every time the dependency is updated. This also attemps to get rid of the error happening with `epub:type` attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- RIP testapp
- Eventually we should come up with a better solution for the css selector code, but should suffice for now
|
Yeah re. css selector, I came across this instance in services: ts-toolkit/shared/src/publication/services/content/iterators/HTMLResourceContentIterator.ts Lines 327 to 360 in 118269d
At first sight it would be tempting to align it on |
This PR removes the vanilla test app and updates dependencies across packages.
This closes #117 through f10ef93 by scripting the modifications needed in CSS Selector Generator dependencies (Navigator > FrameBlobBuilder)
It adds all colon attributes e.g.
epub:typeinblacklistby default when outputting the custom script but maybe we want to scope this. I am not sure at the moment, despite testing the change – because it is tough to encounter edge cases from a limited amount of publications in Thorium Web.