Skip to content

Conversation

@saatvik-10
Copy link
Contributor

Problem

The Password Generator project was displaying a broken image icon in the Trending Plays section.

Root Cause

  • External image URL: https://securityintelligence.com/wp-content/uploads/2018/10/si-eight-character-password-feature.jpg
  • This URL redirects to IBM security page and is no longer accessible as an image

Solution

  • Added local cover.png as fallback following existing pattern
  • The loadCoverImage utility will now find the local file when external URL fails

Testing

  • Verified cover.png exists and is valid PNG format
  • Follows same structure as other plays (analog-clock, etc.)

@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 4540292
🔍 Latest deploy log https://app.netlify.com/projects/reactplayio/deploys/68760e602d25e0000882b21c
😎 Deploy Preview https://deploy-preview-1585--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still it's visible
Image

@saatvik-10
Copy link
Contributor Author

still it's visible Image

Enhanced Image Loading Logic

  • Modified PlayThumbnail.jsx to properly handle external image loading failures
  • Before: if (play.cover) use external, else use local
  • After: try external image → if fails → fallback to local image
  • Added proper error handling with Image() constructor to detect load failures

@saatvik-10 saatvik-10 requested a review from priyankarpal July 15, 2025 08:26
@priyankarpal priyankarpal merged commit 71d303c into reactplay:main Jul 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants