Skip to content

feat(toolbox): Add string utility function for_each_csv_item() to toolbox #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steverough merged 1 commit into from
Nov 17, 2025
Merged

feat(toolbox): Add string utility function for_each_csv_item() to toolbox #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions toolbox/util/String.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <charconv>
#include <cstring>
#include <sstream>
#include <string_view>

namespace toolbox {
inline namespace util {
Expand Down Expand Up @@ -129,8 +130,8 @@ inline std::string trim_copy(std::string s) noexcept
return s;
}

TOOLBOX_API std::pair<std::string_view, std::string_view> split_pair(std::string_view s,
std::string_view delim) noexcept;
TOOLBOX_API std::pair<std::string_view, std::string_view>
split_pair(std::string_view s, std::string_view delim) noexcept;

TOOLBOX_API std::pair<std::string, std::string> split_pair(const std::string& s,
std::string_view delim);
Expand All @@ -140,6 +141,26 @@ TOOLBOX_API std::pair<std::string_view, std::string_view> split_pair(std::string

TOOLBOX_API std::pair<std::string, std::string> split_pair(const std::string& s, char delim);

template <typename F>
void for_each_csv_item(std::string_view csv,
F f) noexcept(noexcept(split_pair(std::declval<std::string_view>(), ','))
&& noexcept(f(std::declval<std::string_view>())))
{
bool trailing_comma;
do {
std::string_view v;
trailing_comma = (!csv.empty() && csv.back() == ',');
std::tie(v, csv) = split_pair(csv, ',');
f(v);
} while (!csv.empty() || trailing_comma);
}

static_assert(noexcept(for_each_csv_item(std::string_view{"a,b"},
[](std::string_view) noexcept {})),
"for_each_csv_item is noexcept(true)");
static_assert(!noexcept(for_each_csv_item(std::string_view{"a,b"}, [](std::string_view) {})),
"for_each_csv_item is noexcept(false)");

/// Returns the length of right-padded string.
/// \tparam PadC The character used for padding.
/// \param src The source string.
Expand Down
66 changes: 66 additions & 0 deletions toolbox/util/String.ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,72 @@ BOOST_AUTO_TEST_CASE(SplitPairCase)
BOOST_CHECK_EQUAL(split_pair(" a = b "s, '='), make_pair(" a "s, " b "s));
}

BOOST_AUTO_TEST_CASE(for_each_csv_item_tests)
{
std::vector<std::string> values;
auto f{[&values](std::string_view value) { values.emplace_back(value); }};
{
values.clear();
auto csv{""sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 1UL);
BOOST_CHECK_EQUAL(values[0], "");
}
{
values.clear();
auto csv{","sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 2UL);
BOOST_CHECK_EQUAL(values[0], "");
BOOST_CHECK_EQUAL(values[1], "");
}
{
values.clear();
auto csv{",,"sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 3UL);
BOOST_CHECK_EQUAL(values[0], "");
BOOST_CHECK_EQUAL(values[1], "");
BOOST_CHECK_EQUAL(values[2], "");
}
{
values.clear();
auto csv{"steve,,"sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 3UL);
BOOST_CHECK_EQUAL(values[0], "steve");
BOOST_CHECK_EQUAL(values[1], "");
BOOST_CHECK_EQUAL(values[2], "");
}
{
values.clear();
auto csv{",steve,"sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 3UL);
BOOST_CHECK_EQUAL(values[0], "");
BOOST_CHECK_EQUAL(values[1], "steve");
BOOST_CHECK_EQUAL(values[2], "");
}
{
values.clear();
auto csv{",,steve"sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 3UL);
BOOST_CHECK_EQUAL(values[0], "");
BOOST_CHECK_EQUAL(values[1], "");
BOOST_CHECK_EQUAL(values[2], "steve");
}
{
values.clear();
auto csv{"steve,woz,'ere"sv};
for_each_csv_item(csv, f);
BOOST_REQUIRE_EQUAL(values.size(), 3UL);
BOOST_CHECK_EQUAL(values[0], "steve");
BOOST_CHECK_EQUAL(values[1], "woz");
BOOST_CHECK_EQUAL(values[2], "'ere");
}
}

BOOST_AUTO_TEST_CASE(PstrlenCase)
{
constexpr char ZeroPad[] = "foo";
Expand Down