Skip to content

Conversation

@bnbajwa
Copy link
Contributor

@bnbajwa bnbajwa commented Oct 23, 2025

std::experimental::propagate_const is better choice as it's documented and tested.

SDB-9943

std::experimental::propagate_const is better choice as it's documented
and tested.

SDB-9943
@bnbajwa bnbajwa requested a review from a team as a code owner October 23, 2025 12:53
@gemini-code-assist
Copy link

Summary of Changes

Hello @bnbajwa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the codebase by removing a custom implementation of propagate_const. The change is driven by the decision to adopt std::experimental::propagate_const, leveraging a standardized and well-vetted solution. This improves maintainability and reduces the burden of custom code, aligning with best practices for using established library features.

Highlights

  • Removal of Custom Implementation: The custom propagate_const class and its associated helper structures (pointed_underlying) have been entirely removed from the toolbox/util/PropagateConst.hpp file.
  • Adoption of Standard Library Feature: The project will now utilize std::experimental::propagate_const, which is a documented and tested alternative, replacing the previously custom-built solution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes the PropagateConst.hpp file, as it's being replaced by std::experimental::propagate_const. I have added a review comment to reflect the removal of the file.

@bnbajwa bnbajwa enabled auto-merge (rebase) October 23, 2025 12:55
@bnbajwa bnbajwa merged commit 3763974 into reactivemarkets:master Oct 23, 2025
5 checks passed
@bnbajwa bnbajwa deleted the util branch November 4, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants