Skip to content

Bugfix of missing keys in deep objects #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsdevlondon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix of missing keys in deep objects #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ var diff = function(defaults,source){
}

}else{
var tmp = diff(defaults[key],value)
if(_.isEmpty(tmp)){
delete result[key]
if(typeof defaults[ key ] === "undefined"){
result[ key ] = value
}else{
result[key]=tmp
var tmp = diff(defaults[ key ], value)
if (_.isEmpty(tmp)) {
delete result[ key ]
} else {
result[ key ] = tmp
}
}
}

Expand Down
8 changes: 6 additions & 2 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,15 @@ describe("object deep diff",function(){

var sourceObj = {a:{b:{c:"hello"}}}
var sourceObj1 = {a:{b:{c:"hello world"}}}

var sourceObj2 = {a:{d:{e:"hello world"}}}

var result = diff(defaultsObj,sourceObj)
var result1 = diff(defaultsObj,sourceObj1)

var result2 = diff(defaultsObj,sourceObj2)

expect(result).to.deep.equal({})
expect(result1).to.deep.equal(sourceObj1)
expect(result2).to.deep.equal(sourceObj2)

})
})