Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pack.cc
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ static Handle<Value> unpack(const Arguments& argv)

memcpy(&v, &input[inputpos], sizeof(float));
//add_assoc_double(return_value, n, (double)v);
return_value->Set( String::New(n), Integer::New(v) );
return_value->Set( String::New(n), Number::New(v) );
break;
}

Expand All @@ -991,7 +991,7 @@ static Handle<Value> unpack(const Arguments& argv)

memcpy(&v, &input[inputpos], sizeof(double));
//add_assoc_double(return_value, n, v);
return_value->Set( String::New(n), Integer::New(v) );
return_value->Set( String::New(n), Number::New(v) );
break;
}

Expand Down
1 change: 1 addition & 0 deletions test/floats.json

Large diffs are not rendered by default.

22 changes: 21 additions & 1 deletion test/test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,26 @@
#!/usr/bin/node

var pack = require( "hipack" );
var assert = require ('assert');

function UnpackFloatTest()
{
var data = require ('./floats.json');
data.forEach (function (d) {
var tolerance = 1e-6;

var p = pack.pack ('f', d);
var r = (pack.unpack ('fresult', p)).result;

var min = Math.min (Math.abs (d), Math.abs (r));
if (min === 0) {
/* avoid NaNs */
min = 1;
}
var diff = Math.abs (d - r);
assert (diff / min < tolerance, d + ' !== ' + r + ' (' + diff / min + ')');
});
}

function SimpleTest()
{
Expand All @@ -12,7 +31,7 @@ function SimpleTest()
console.dir( (buf) );

console.log("\nSimple Text Sample : Converting Array of 3 VARs \nCalling pack.pack( 'VVC', [65,66,67] )" );
var buf = pack.pack( "VVC", [ 65,66,67 ] );
buf = pack.pack( "VVC", [ 65,66,67 ] );
console.log( "Result Buffer : " );
console.dir( (buf) );

Expand All @@ -24,3 +43,4 @@ function SimpleTest()
}

SimpleTest();
UnpackFloatTest();