Fix the default implementation of Differentiable for Hashable#115
Open
yunhao wants to merge 2 commits intora1028:masterfrom
Open
Fix the default implementation of Differentiable for Hashable#115yunhao wants to merge 2 commits intora1028:masterfrom
yunhao wants to merge 2 commits intora1028:masterfrom
Conversation
houndci-bot
reviewed
Sep 11, 2020
|
Thanks for putting this in - I also think this is how it should work with Would be nice to have this merged with the documentation reflecting the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The default implementation of Differentiabe for Hashable has a
differenceIdentifierproperty. The implementation of this propeprty now returnhashValueinstead ofself.Related Issue
The above code produces a
delete -> insertchange, however, it should be aupdatechange.#114: Unexpected behavior when using the default implementations of
DifferentiableforHashableMotivation and Context
Close #114
Impact on Existing Code
If the existing code rely on the default implementation of Differentiable for Hashable, the reload behavior may changes. Some
delete -> insertchanges will becomeupdatechanges.