sort evaluated arguments in formals' order to ensure cache hit#89
Open
bluaze wants to merge 8 commits intor-lib:mainfrom
Open
sort evaluated arguments in formals' order to ensure cache hit#89bluaze wants to merge 8 commits intor-lib:mainfrom
bluaze wants to merge 8 commits intor-lib:mainfrom
Conversation
added 8 commits
May 8, 2019 16:03
This reverts commit 7f0325f.
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
===========================================
- Coverage 77.37% 61.13% -16.25%
===========================================
Files 5 5
Lines 221 229 +8
===========================================
- Hits 171 140 -31
- Misses 50 89 +39
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the function has multiple default arguments or the default argument is not defined at the end of formal list, whether the default values are passed explicitly (by call) or implicitly (by default mechanism) may matter
the last 2 call are essentially same, but would have called
fntwice. that is because default values are attached toargsignoring their order in formals. sort them in original order would solve this.