evaluate default args in a dedicated environment#88
Open
bluaze wants to merge 6 commits intor-lib:mainfrom
Open
evaluate default args in a dedicated environment#88bluaze wants to merge 6 commits intor-lib:mainfrom
bluaze wants to merge 6 commits intor-lib:mainfrom
Conversation
added 6 commits
May 8, 2019 16:03
This reverts commit 7f0325f.
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
===========================================
- Coverage 77.37% 60.79% -16.59%
===========================================
Files 5 5
Lines 221 227 +6
===========================================
- Hits 171 138 -33
- Misses 50 89 +39
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
each default arguments not called is assigned to a dedicated environment as promise, just like how R initialize evaluation frame of function call, and the enclosure of the environment is set to the enclosure of the function. then values of default arguments are retrieved from the environment.
would fix #64