function to be memoised with argument that is function, which might be passed another memoised function #86
Open
bluaze wants to merge 4 commits intor-lib:mainfrom
Open
function to be memoised with argument that is function, which might be passed another memoised function #86bluaze wants to merge 4 commits intor-lib:mainfrom
bluaze wants to merge 4 commits intor-lib:mainfrom
Conversation
added 4 commits
May 8, 2019 16:03
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 77.37% 59.9% -17.47%
==========================================
Files 5 5
Lines 221 222 +1
==========================================
- Hits 171 133 -38
- Misses 50 89 +39
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a function to be memoised, say
f, has an argumentfnthat accepts function. If such argumentfnis passed another memoised function, saygm <- memoise(g), the memoisedf's cache may not hit as the hash in the memoisedfwould change whengmis executed with new arguments and new key-value pairs are stored togm's cache and the hash digest not only thegmitself but also its enclosing environment, which contains the caching environmenthere is an example
to avoid hash the entire
gm, the originalgcould be used instead, and to avoidg's own enclosing environment problem andsrcrefproblem, as can be seen in #84,as.character(body(g))might be more appropriate