A cache function to cache arbitrary R code#40
Open
jimhester wants to merge 2 commits intor-lib:mainfrom
Open
Conversation
Member
Author
|
@hadley this is not exactly the API you were prototyping as it does not take a filename parameter, instead the filenames (if you are using the filesystem backend) are a hash of the function body. |
hadley
reviewed
Apr 26, 2017
| #' @export | ||
| cache <- function(code, ..., envir = parent.frame(), cache = cache_memory()) { | ||
| expr <- substitute(code) | ||
| key <- cache$digest(c(expr, lapply(list(...), function(x) eval(x[[2L]], environment(x))))) |
Member
There was a problem hiding this comment.
Is the eval necessary here? Won't list(...) force all the promises?
hadley
reviewed
Apr 26, 2017
R/cache.R
Outdated
| f <- function() NULL | ||
| body(f) <- expr | ||
| environment(f) <- envir | ||
| (memoise(f, envir = envir, ..., cache = cache))() |
Member
There was a problem hiding this comment.
Why not just do cache$set(key, f()) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept, caching arbitrary R code.
This uses the existing memoise machinery to compute a hash based on the input code / expression and any additional variables (specified as formulas in
...), so does not take a cache filename.You can use it with the in-memory cache, but you need to specify the cache up front, otherwise a new cache is created on every invocation.
Improvements would be to use rlang to construct the function and quote the code / extra arguments. We would also need to change how the
...arguments are handled in regular memoise to userlang::dots_quos()andrlang::tidy_eval().