Draft
Conversation
GTAD 0.11.0 was broken.
Actually, it's just one place.
|
Note: aside from changes in gtad.yaml, matrix-spec was also changed to suppress unneeded QJsonObjects by new jobs in report_content.h
Member
|
This breaks compilation of neochat in a few places. Ifdefing those is easy enough, but it would help a lot to have a preprocessor definition that contains the version of the matrix api |
Member
Author
|
If it's because of |
Member
|
It's not RoomKeysUpdateResponse. One is ReportContentJob being gone, the others are two cases of QStrings now being QUrls |
Member
Author
|
Ah, doh, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+Reformatting according to updated .clang-format, making the PR look bigger than it really is. The key things are in 91c672c.