forked from Dash-Industry-Forum/dash.js
-
Notifications
You must be signed in to change notification settings - Fork 0
[POC] Global sync #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sebastianpiq
wants to merge
43
commits into
feature/cmcdv2
Choose a base branch
from
poc/global-sync
base: feature/cmcdv2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t object with updated properties
Cmcdv2/response mode
Cmcdv2/interceptor sample page
* Add event mode listeners and state change handling in CmcdController * Add event mode properties and initialize time interval in CmcdController * Added requestType to events sent to frontend * Created constants for CMCD Events, updated CmcdController to use said constants * Renamed Targets.keys to Targets.enabledKeys * Renamed cmcd.targets.mode to cmcd.targets.cmcdMode * Using all available keys for targets if no enabledKeys are configured * Added logic to use all events if no target.Events is defined * Added Filter for targets.Events --------- Co-authored-by: juanmanuel-qualabs <juanmanuel@qualabs.com>
Added code to always include TS key in Event Mode events
CMCD V2 - Mandatory Keys
* Implemented rebuffering key only when an unexpected buffer starvation occurs * Added events to reset() method * Removed duplicated event bus attachment
042af7e to
7a9cff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.