This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Create PyVelox package and move type dependencies over.#503
Open
Create PyVelox package and move type dependencies over.#503
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kgpai
added a commit
that referenced
this pull request
Oct 13, 2022
Summary: PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings. Pull Request resolved: #503 Differential Revision: D40082189 Pulled By: kgpai fbshipit-source-id: 83427b5aee17eef5470f93129200fcd215286fa2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40082189 |
kgpai
added a commit
that referenced
this pull request
Oct 14, 2022
Summary: PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings. Pull Request resolved: #503 Differential Revision: D40082189 Pulled By: kgpai fbshipit-source-id: f1404f4e1284bd8f0f39e547348d228c3fe11abd
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40082189 |
kgpai
added a commit
that referenced
this pull request
Oct 14, 2022
Summary: PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings. Pull Request resolved: #503 Reviewed By: wenleix Differential Revision: D40082189 Pulled By: kgpai fbshipit-source-id: 36a6a14e9c00b881a1d5c40512ac9fa36a2199a2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40082189 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40082189 |
kgpai
added a commit
that referenced
this pull request
Oct 14, 2022
Summary: PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings. Pull Request resolved: #503 Reviewed By: wenleix Differential Revision: D40082189 Pulled By: kgpai fbshipit-source-id: 93ce2c3892343e4ef9bbe01589b51ef20efa15eb
Summary: PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings. Pull Request resolved: #503 Reviewed By: wenleix Differential Revision: D40082189 Pulled By: kgpai fbshipit-source-id: 069aed8ecf2275b0cc0ce3e223fe7d83e0678589
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40082189 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Summary: PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings. Pull Request resolved: #503 Reviewed By: wenleix Differential Revision: D40082189 Pulled By: kgpai fbshipit-source-id: 925f3808cc8429e36d37e084abf73df2596a6346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyVelox package is gated with CMake flags in this pr. This refactoring will allow Torcharrow and Koski to use a common set of bindings.