This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Decouple the building of benchmarks and tests (#2439)#491
Open
kgpai wants to merge 1 commit intopytorch:fbsyncfrom
Open
Decouple the building of benchmarks and tests (#2439)#491kgpai wants to merge 1 commit intopytorch:fbsyncfrom
kgpai wants to merge 1 commit intopytorch:fbsyncfrom
Conversation
Summary: Tests and benchmarks targets are now de-coupled. That means they can be built independently. Shared functionality is moved to a common utility library. Resolves facebookincubator/velox#1704 X-link: facebookincubator/velox#2439 Reviewed By: Yuhta Differential Revision: D39484543 Pulled By: kgpai fbshipit-source-id: b8b0f3a2fec4651ee8b4fe9ca6304bd37b9be183
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39484543 |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Sep 15, 2022
Summary: X-link: pytorch/torcharrow#491 Tests and benchmarks targets are now de-coupled. That means they can be built independently. Shared functionality is moved to a common utility library. Resolves #1704 Pull Request resolved: #2439 Reviewed By: Yuhta Differential Revision: D39484543 Pulled By: kgpai fbshipit-source-id: 5ac888c81a6bbfbc5a1a1c4cfd41fa2c86199bc4
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Summary: Pull Request resolved: #491 Tests and benchmarks targets are now de-coupled. That means they can be built independently. Shared functionality is moved to a common utility library. Resolves facebookincubator/velox#1704 X-link: facebookincubator/velox#2439 Reviewed By: Yuhta Differential Revision: D39484543 Pulled By: kgpai fbshipit-source-id: 5ac888c81a6bbfbc5a1a1c4cfd41fa2c86199bc4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tests and benchmarks targets are now de-coupled.
That means they can be built independently.
Shared functionality is moved to a common utility library.
Resolves facebookincubator/velox#1704
X-link: facebookincubator/velox#2439
Reviewed By: Yuhta
Differential Revision: D39484543
Pulled By: kgpai