Skip to content

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Dec 25, 2025

Summary

This PR correctly identifies that ConvertToCortexMPass inherits from XNNPACKPass and properly passes it the exported_program() argument:

  • ReplaceQuantNodesPass → issubclass(XNNPACKPass) = False → instantiated as pass_cls()
  • ConvertToCortexMPass → issubclass(XNNPACKPass) = True → instantiated as pass_cls(exported_program()) ✓
  • QuantizedOpFusionPass → issubclass(XNNPACKPass) = False → instantiated as pass_cls()

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

python3 -m examples.arm.aot_arm_compiler -m mv2 --target=ethos-u55-128 --quantize --enable_qdq_fusion_pass --output=./output/mv2_cmsis

Without this change, the error would be
File "/home/sidart/executorch/examples/arm/aot_arm_compiler.py", line 808, in transform_for_cortex_m_backend
else pass_cls()
TypeError: XNNPACKPass.init() missing 1 required positional argument: 'exported_program'"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16393

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit 6fc9d49 with merge base d4ce813 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 25, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh psiddh changed the title To be abe to export mv3/mv2 with 'enabke-qdq' flag and export mv3 Prerequiste changes to export mv3/mv2 targetting CMSIS-NN backend Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant