-
Notifications
You must be signed in to change notification settings - Fork 294
break: drop unused riscv64 enable option #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This will break some users, holding for a future major or minor release. |
|
I think a future minor release should be fine, like 3.3, since it was experimental and probably doesn't have a huge number of users. Fine to wait for 4.0 if others think differently, though. |
|
Something like 3.3 sounds good |
mayeut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're now after 3.3.0, I think it's fine to merge, even if the next version is 3.3.1
Fixes #2509
cc @mayeut