Skip to content

EV3: Fix flashing on Windows. #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaguilar wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

EV3: Fix flashing on Windows. #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pybricksdev/connections/ev3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,17 @@ def _send_command(self, command: Command, payload: bytes | None = None) -> int:

length += len(payload)

# report_id is not used by the EV3 but is required by HIDAPI on Windows.
# It does no harm on Linux, so we include it unconditionally. Note that
# the report ID is automatically stripped from incoming messages by
# HIDAPI on all platforms.
report_id = 0

message_number = next(self._msg_count)

message = struct.pack(
"<HHBB",
"<BHHBB",
report_id,
length,
message_number,
MessageType.SYSTEM_COMMAND_REPLY,
Expand Down