This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Pass CSRF token in asset upload request #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged into tagged version soon? |
|
Hmm. there is an issue with this though -- you need to also add the fix to the Media -> Update Media menu workflow. otherwise you end up with this when you update an asset: |
|
What release will this go in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #49. I faced the same issue with Rails 5.2 and push_type 0.12.1. Upon checking the parameters sent to
PushType::Admin::AssetsController#uploadI found thatauthenticity_tokenfield was missing.[https://discuss.pushtype.org/t/unprocessable-entity-upon-an-asset-upload/349](Forum thread)