Additional query functions; additional graph construction functions; switch to set of edges#10
Open
colehaus wants to merge 10 commits intopurescript:masterfrom
Open
Additional query functions; additional graph construction functions; switch to set of edges#10colehaus wants to merge 10 commits intopurescript:masterfrom
colehaus wants to merge 10 commits intopurescript:masterfrom
Conversation
Also, the implementation is less buggy
Author
|
FYI, I don't think the Travis failure has much to do with the changes here. The message is |
|
why is this still not merged |
NickHu
suggested changes
Aug 6, 2020
| -- | | ||
| -- | Edges refer to vertices using keys of type `k`. | ||
| newtype Graph k v = Graph (Map k (Tuple v (List k))) | ||
| newtype Graph k v = Graph (Map k (Tuple v (Set k))) |
There was a problem hiding this comment.
This prevents the possibility of having multiple edges between any pair of nodes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of changes bundled together. I'm happy to split these into separate PRs if that's helpful, but I thought I'd put it all out for discussion first.